Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in self-hosted runners architecture labels #31079

Closed
wants to merge 2 commits into from
Closed

Fix typo in self-hosted runners architecture labels #31079

wants to merge 2 commits into from

Conversation

garysassano
Copy link
Contributor

Why:

The main self-hosted runners page mentions ARM32 as an architecture, while elsewhere that's referenced simply as ARM so it must be wrong in one place.

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 13, 2024
Copy link
Contributor

github-actions bot commented Jan 13, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/hosting-your-own-runners/managing-self-hosted-runners/using-self-hosted-runners-in-a-workflow.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836
Copy link
Contributor

@garysassano Thanks so much for opening a PR! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jan 15, 2024
@orhannoguz356

This comment was marked as spam.

Copy link
Contributor

@SiaraMist SiaraMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this, @garysassano! ✨ I'll go ahead and get it merged.

Oops, I approved this too soon, apologies. If you go to one of your repositories and add a self-hosted runner, you'll see that when you choose a runner with a Linux operating system, the choices for available architectures are x64, ARM, and ARM64. Whichever architecture you chose would then be added as a label to the runner, which matches what the article you are updating says. If you set the runs-on key to runs-on: [self-hosted, linux, ARM32], it would not work because ARM32 would not be an accurate runner label. In light of that, I'm going to close this pull request. We really appreciate you thinking critically about the docs and making fixes!

@SiaraMist SiaraMist enabled auto-merge January 17, 2024 19:35
@SiaraMist SiaraMist disabled auto-merge January 17, 2024 19:37
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Jan 17, 2024
@SiaraMist SiaraMist removed this pull request from the merge queue due to a manual request Jan 17, 2024
@SiaraMist SiaraMist closed this Jan 17, 2024
@garysassano
Copy link
Contributor Author

@SiaraMist So It was probably this page that needed to be aligned for consistency in naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants