-
Notifications
You must be signed in to change notification settings - Fork 60.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in self-hosted runners architecture labels #31079
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@garysassano Thanks so much for opening a PR! I'll get this triaged for review ✨ |
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating this, @garysassano! ✨ I'll go ahead and get it merged.
Oops, I approved this too soon, apologies. If you go to one of your repositories and add a self-hosted runner, you'll see that when you choose a runner with a Linux operating system, the choices for available architectures are x64, ARM, and ARM64. Whichever architecture you chose would then be added as a label to the runner, which matches what the article you are updating says. If you set the runs-on
key to runs-on: [self-hosted, linux, ARM32]
, it would not work because ARM32
would not be an accurate runner label. In light of that, I'm going to close this pull request. We really appreciate you thinking critically about the docs and making fixes!
@SiaraMist So It was probably this page that needed to be aligned for consistency in naming. |
Why:
The main self-hosted runners page mentions
ARM32
as an architecture, while elsewhere that's referenced simply asARM
so it must be wrong in one place.Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.