Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default run-name triggered by pull_request event #32267

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

muzimuzhi
Copy link
Contributor

@muzimuzhi muzimuzhi commented Mar 28, 2024

Why:

Closes: #32266

What's being changed (if available, include any code snippets, screenshots, or gifs):

Update docs according to current behavior of GitHub Actions, in which the default run-name of workflow runs triggered by pull_request event, found on "Actions" tab, uses PR title, not commit message.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 28, 2024
@muzimuzhi
Copy link
Contributor Author

https://github.com/github/docs/actions/runs/8470303578/job/23207709363?pr=32267 failed with a TLS handshake timeout:

(newlines and indents added by me)

Error: buildx failed with: ERROR:
  failed to solve: node:20-alpine@sha256:bf77dc26e48ea95fca9d1aceb5acfa69d2e546b765ec2abfb502975f1a2d4def:
  failed to resolve source metadata for docker.io/library/node:20-alpine@sha256:bf77dc26e48ea95fca9d1aceb5acfa69d2e546b765ec2abfb502975f1a2d4def:
  failed to do request: Head "https://registry-1.docker.io/v2/library/node/manifests/sha256:bf77dc26e48ea95fca9d1aceb5acfa69d2e546b765ec2abfb502975f1a2d4def":
  net/http: TLS handshake timeout

@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Mar 28, 2024
@nguyenalex836
Copy link
Contributor

@muzimuzhi Thanks so much for opening a PR! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added the content This issue or pull request belongs to the Docs Content team label Mar 28, 2024
R0nni333

This comment was marked as spam.

@muzimuzhi muzimuzhi force-pushed the actions-pullrequest-run-name branch from f86baab to a8bd9b9 Compare March 31, 2024 15:31
Copy link
Contributor

github-actions bot commented Mar 31, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-syntax-for-github-actions.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

Copy link
Contributor

@SiaraMist SiaraMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for updating the docs @muzimuzhi, and for providing examples to verify your changes in the issue you opened. ✨

I just made a small edit to match our style guide, and I'll go ahead and get this merged.

@SiaraMist SiaraMist closed this Apr 8, 2024
@SiaraMist SiaraMist reopened this Apr 8, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 8, 2024
@nguyenalex836 nguyenalex836 removed triage Do not begin working on this issue until triaged by the team waiting for review Issue/PR is waiting for a writer's review labels Apr 8, 2024
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Apr 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2024
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Apr 8, 2024
Merged via the queue into github:main with commit 06b6961 Apr 8, 2024
42 checks passed
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@muzimuzhi muzimuzhi deleted the actions-pullrequest-run-name branch April 8, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default run-name of workflow run triggered by pull_request
4 participants