Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update_access_control #34451

Closed
wants to merge 1 commit into from
Closed

Update_access_control #34451

wants to merge 1 commit into from
+1 −1

Conversation

Swastik-Swarup-Dash
Copy link

updated docs for easier understanding About access control

@welcome Welcome
Copy link

welcome bot commented Aug 30, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pages/getting-started-with-github-pages/changing-the-visibility-of-your-github-pages-site.md ghec
 ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels Aug 30, 2024
@nguyenalex836
Copy link
Contributor

@Swastik-Swarup-Dash Thanks for opening a PR!

updated docs for easier understanding About access control

Can you elaborate on how your updates make this doc easier to understand? 💛

@nguyenalex836 nguyenalex836 added the more-information-needed More information is needed to complete review label Aug 30, 2024
@Swastik-Swarup-Dash
Copy link
Author

Hey,By making it shorter and use of understandable wordings which are not so complex as earlier

@nguyenalex836
Copy link
Contributor

@Swastik-Swarup-Dash Thank you for explaining! Unfortunately since these changes are mainly personal preferences on how to phrase something, rather than corrections or improvements, we won't be able to accept this contribution 💛

If you'd like to make changes I'd recommend raising an improvement issue here, then someone from the team can take a look at your proposal before you submit your PR ✨

Check out https://docs.github.com/en/contributing for more information about contributing, and our house style.

@Swastik-Swarup-Dash Swastik-Swarup-Dash deleted the update_gitpage branch September 7, 2024 19:25
@nguyenalex836 nguyenalex836 mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review pages Content related to GitHub Pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swastik-Swarup-Dash @nguyenalex836