-
Notifications
You must be signed in to change notification settings - Fork 59.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing originalUriBaseIds property from the SARIF specification #35043
base: main
Are you sure you want to change the base?
Missing originalUriBaseIds property from the SARIF specification #35043
Conversation
Fix invalid SARIF specification, missing originalUriBaseIds from the format
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@marcandre-larochelle-bell Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
This comment was marked as spam.
This comment was marked as spam.
@nguyenalex836 I think a bot / fake account is trying to sneak-in some participation on this MR (check the empty comment above) |
@marcandre-larochelle-bell They've been blocked 💛 |
The SARIF format specified in the documentation is missing a field allowing resolution of the references for SARIF consumers (which is invalid):
SARIF Producer file scheme instructions (see Step 6 of when the URI is split)
And related to the originalUriBaseIds the property:
Why:
As per the SARIF specification:
Multiple vendors are following GitHub's documentation here and omitting the originalUriBaseIds during their implementation, making it impossible to perform the above mentioned relative references resolution for other SARIF consumers. This is to correct this missing property.
What's being changed (if available, include any code snippets, screenshots, or gifs):
Added the property
originalUriBaseIds
with the example data from the SARIF specification.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.