Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Ambiguity :workflow_dispatch statement about "default branch" #35708

Closed
wants to merge 7 commits into from

Conversation

lalithaar
Copy link
Contributor

Changed the sentence according to SME recommendation.

Why:

Improves clarity on triggering the workflow

Closes: #35318

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 19, 2024
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
discussions/guides/best-practices-for-community-conversations-on-github.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
actions/about-github-actions/understanding-github-actions.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/writing-workflows/about-workflows.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/security-for-github-actions/security-guides/using-githubs-security-features-to-secure-your-use-of-github-actions.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
admin/managing-code-security/managing-github-advanced-security-for-your-enterprise/configuring-dependency-review-for-your-appliance.md ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
code-security/supply-chain-security/understanding-your-software-supply-chain/about-dependency-review.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-dependency-changes-in-a-pull-request.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@lalithaar
Copy link
Contributor Author

I am unsure of why it's showing already merged commits as I am new to contributions. I will look it up. But I hope the procedure is right. Please let me know if you have any feedbacks

@nguyenalex836
Copy link
Contributor

@lalithaar Great to see you again - thank you for opening this PR!

I am unsure of why it's showing already merged commits as I am new to contributions.

Would you be open to creating a new branch for this PR, and see if that problem persists? 💛

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team more-information-needed More information is needed to complete review and removed triage Do not begin working on this issue until triaged by the team labels Dec 19, 2024
@lalithaar lalithaar closed this Dec 20, 2024
@lalithaar
Copy link
Contributor Author

@nguyenalex836 just created a PR and the issue is resolved now :> Thank you for being so kind and helpful!!
Link to new PR

@nguyenalex836
Copy link
Contributor

Thank you for being contributing to our docs! 💛 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous on:workflow_dispatch statement about "default branch"
2 participants