Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file-attachments-on-issues-and-pull-requests.md #3710

Closed
wants to merge 1 commit into from

Conversation

daminebenq
Copy link

@daminebenq daminebenq commented Feb 15, 2021

Why:

Now Github supports mp4 file attachments. So i saw that it is missing in this list.

What's being changed:

file-1.mp4

Check off the following:

@welcome
Copy link

welcome bot commented Feb 15, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@daminebenq Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Feb 17, 2021
@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@felicitymay
Copy link
Contributor

👋🏻 Hi @daminebenq - thanks for taking the time to open this PR.

You're right to say that GitHub now supports mp4 attachments. It was announced as a beta feature: https://github.blog/changelog/2020-12-16-video-upload-public-beta/ and https://github.blog/changelog/2021-02-01-expanded-support-for-video-uploads/.

It looks as if someone else has also opened a PR to update to this page. Since that PR also adds the limit on file sizes, I'm closing your PR in favor of: #3571.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants