Update PR template #451
Merged
Update PR template #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lee-dohm
approved these changes
Oct 12, 2020
simpsoka
reviewed
Oct 12, 2020
|
|
||
| <!-- | ||
| Hello! Thanks for your interest in contributing to this project. | ||
| Thank you for contributing to this project! You must fill out the information below before we can review this pull request. Explaining why you're making a change (or linking to a pull request) and what changes you've made, we can triage your pull request to the best possible team for review. |
There was a problem hiding this comment.
This sentence reads a little funny to me. I think it's the gerund. Maybe,
Explaining why you're making a change and what changes you've made will help us triage your pull request and get it reviewed by the best team possible.
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
This is a tweak to the pull request template to help contributors understand that we need this information before the docs team can triage and review a pr.
What's being changed:
The commented out information at the top of the PR has been trimmed. I also added a line about how we can't accept PRs for translated content.
Check off the following: