-
Notifications
You must be signed in to change notification settings - Fork 60.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in search part of contribution guideline #477
Fix typos in search part of contribution guideline #477
Conversation
👋 Thanks for fixing the typos @tnir! Could you either remove the changes you made to the readme or open a new PR without them and close this one? You can add yourself to the list of contributors by creating a new comment in this (or the new, updated) PR using these instructions. Thanks again! ✨ Using the command helps us to keep track of the changes with all contributors. Thank you! |
e462c53
to
8f646d8
Compare
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
8f646d8
to
d5994bd
Compare
@all-contributors please add @tnir for Maintenance |
I've put up a pull request to add @tnir! 🎉 |
@janiceilene Thanks for your suggestion. Just removed changes from contributors and created #506. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @tnir 🎉 I'll update the branch and get this merged once tests are green 🍏
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨ |
Why:
The less typos, the easier to read.
What's being changed:
Fix typos in search part of contribution guideline.
Check off the following: