Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in search part of contribution guideline #477

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Oct 13, 2020

Why:

The less typos, the easier to read.

What's being changed:

Fix typos in search part of contribution guideline.

Check off the following:

@janiceilene
Copy link
Contributor

👋 Thanks for fixing the typos @tnir! Could you either remove the changes you made to the readme or open a new PR without them and close this one? You can add yourself to the list of contributors by creating a new comment in this (or the new, updated) PR using these instructions. Thanks again! ✨

Using the command helps us to keep track of the changes with all contributors. Thank you!

@tnir tnir force-pushed the typos-in-contributing-search-guide branch from e462c53 to 8f646d8 Compare October 14, 2020 00:09
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir tnir force-pushed the typos-in-contributing-search-guide branch from 8f646d8 to d5994bd Compare October 14, 2020 00:10
@tnir
Copy link
Contributor Author

tnir commented Oct 14, 2020

@all-contributors please add @tnir for Maintenance

@allcontributors
Copy link
Contributor

@tnir

I've put up a pull request to add @tnir! 🎉

@tnir
Copy link
Contributor Author

tnir commented Oct 14, 2020

@janiceilene Thanks for your suggestion. Just removed changes from contributors and created #506.

Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @tnir 🎉 I'll update the branch and get this merged once tests are green 🍏

@janiceilene janiceilene merged commit adc56bb into github:main Oct 14, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@tnir tnir deleted the typos-in-contributing-search-guide branch October 14, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants