Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and extend push webhook documentation. #499

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Fix and extend push webhook documentation. #499

merged 3 commits into from
Oct 20, 2020

Conversation

coling
Copy link
Contributor

@coling coling commented Oct 13, 2020

Why:

I implemented a webhook to handle pushes but the payload was not the same as the docs. I found the commits had an id attribute rather than an sha one as per the docs.

What's being changed:

image

Check off the following:

coling added 2 commits October 13, 2020 20:35
@coling
Correct the commits SHA key name.
211edbf 
When setting up a webhook recently I found the objects in the commits array did not have an 'sha' element, but did have an 'id'.
@coling
Describe some more elements of the commit object
05e4d63 
Document the timestamp, added, modified and removed keys of the commit object.
@welcome
Copy link

welcome bot commented Oct 13, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks so much for opening a PR @coling! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 14, 2020
@lucascosti lucascosti self-assigned this Oct 20, 2020
lucascosti
lucascosti approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this, @coling! I'll get this merged in 🚀

@lucascosti lucascosti merged commit acec423 into github:main Oct 20, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@coling coling deleted the patch-1 branch October 20, 2020 13:09
@snyk-bot snyk-bot mentioned this pull request Jul 7, 2022
Open
@montana910318 montana910318 mentioned this pull request Jul 7, 2022
Open
@treeations treeations mentioned this pull request Jul 7, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jul 7, 2022
Open
@strezless strezless mentioned this pull request Jul 7, 2022
Open
@muratkalenderoglu muratkalenderoglu mentioned this pull request Jul 7, 2022
Open
This was referenced Jul 7, 2022
Open
Open
@shga1993 shga1993 mentioned this pull request Jul 7, 2022
Open
@ramsemune ramsemune mentioned this pull request Jul 7, 2022
Open
This was referenced Jul 7, 2022
Open
Open
Open
Open
@shats15 shats15 mentioned this pull request Jul 7, 2022
Open
@muratkalenderoglu muratkalenderoglu mentioned this pull request Jun 23, 2023
Open
@golfviva golfviva mentioned this pull request Jun 23, 2023
Open
@Jccp1983 Jccp1983 mentioned this pull request Jun 23, 2023
Open
@shats15 shats15 mentioned this pull request Jun 24, 2023
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Jun 24, 2023
Open
@ZRDKPoWeR ZRDKPoWeR mentioned this pull request Jun 24, 2023
Open
@roru78 roru78 mentioned this pull request Jun 24, 2023
Open
@ayvazjet ayvazjet mentioned this pull request Jun 24, 2023
Open
@zipzip225 zipzip225 mentioned this pull request Jun 24, 2023
Open
@taeb3 taeb3 mentioned this pull request Jun 24, 2023
Merged
@ramsemune ramsemune mentioned this pull request Jun 24, 2023
Open
@Anmar1988260 Anmar1988260 mentioned this pull request Jun 24, 2023
Open
@dmvol81 dmvol81 mentioned this pull request Jun 24, 2023
Open
@montana910318 montana910318 mentioned this pull request Jun 24, 2023
Open
@rhsayem075 rhsayem075 mentioned this pull request Jun 24, 2023
Open
@Oleksandr1201vsp Oleksandr1201vsp mentioned this pull request Jun 24, 2023
Open
@w124578 w124578 mentioned this pull request Jun 24, 2023
Open
@chrisjcox79 chrisjcox79 mentioned this pull request Jun 24, 2023
Open
@treeations treeations mentioned this pull request Jun 24, 2023
Open
@mitrostziavarasgr mitrostziavarasgr mentioned this pull request Jun 24, 2023
Open
@dotam99 dotam99 mentioned this pull request Jun 24, 2023
Open
@pinpc pinpc mentioned this pull request Jun 24, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Jun 24, 2023
Open
@dev2dark dev2dark mentioned this pull request Jun 24, 2023
Open
@mongoloidkhulmikuki366385 mongoloidkhulmikuki366385 mentioned this pull request Jun 24, 2023
Open
@989919259920 989919259920 mentioned this pull request Jun 24, 2023
Open
@Visva92 Visva92 mentioned this pull request Jun 24, 2023
Open
@francissimo francissimo mentioned this pull request Jun 24, 2023
Open
@kabat87 kabat87 mentioned this pull request Jun 25, 2023
Open
@B020239 B020239 mentioned this pull request Jun 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucascosti lucascosti lucascosti approved these changes

Assignees

@lucascosti lucascosti

Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coling @janiceilene @lucascosti