Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example to echo out put from previous step fails #528

Merged
merged 4 commits into from
Oct 16, 2020

Conversation

bcbrian
Copy link
Contributor

@bcbrian bcbrian commented Oct 14, 2020

Why:

I copied and pasted this piece out of the docs and it did not work.
The error is a bash error: bad substitution.

Link to the change

What's being changed:

change - run: echo 'The selected color is' ${steps.random-color-generator.outputs.SELECTED_COLOR}
to - run: echo "The selected color is ${{ steps.random-color-generator.outputs.SELECTED_COLOR }}"

Other parts of the docs have it formatted this way.

Check off the following:

change - run: echo 'The selected color is' ${steps.random-color-generator.outputs.SELECTED_COLOR}
to - run: echo "The selected color is ${{ steps.random-color-generator.outputs.SELECTED_COLOR }}"

Other parts of the docs have it formatted this way. The error is a bash error:  bad substitution.
@welcome
Copy link

welcome bot commented Oct 14, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks so much for opening a PR @bcbrian! I'll get this triaged and up for review ⚡

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 15, 2020
@lucascosti lucascosti self-assigned this Oct 16, 2020
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, @bcbrian! 🚀

Thanks for fixing this, I'll get it merged when the tests from the rebase pass 👍

@lucascosti lucascosti merged commit 70d6d85 into github:main Oct 16, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants