Fixed broken links in README.md #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I included the link to the contributing doc file
Fixed the broken link in README.md for markup reference guide
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
janiceilene
requested changes
Oct 15, 2020
There was a problem hiding this comment.
Thank you so much for fixing these links @Anita-ihuman 🎉 I made two small suggestions to make these into internal links so the links will still work on folks' forks. Once you accept those suggestions, I'll get this merged in 💖
Co-authored-by: Janice <janiceilene@github.com>
oh! Thank you. Co-authored-by: Janice <janiceilene@github.com>
Anita-ihuman
commented
Oct 16, 2020
Anita-ihuman
commented
Oct 18, 2020
|
This looks great @Anita-ihuman, thank you so much! I'll get this branch updated and merged once tests are passing 💖 |
janiceilene
approved these changes
Oct 19, 2020
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
Co-authored-by: Jacob Prall <colossus@Jacobs-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The existing links on the README.md for contributing guide and makeup reference guide were all throwing error 404 page not found.
What's being changed:
This PR is a fix for issue no #524 and #525. It takes care of the broken links for the contributing guide and the makeup reference guide.
Check off the following: