Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the autoupdatebranch Action #563

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fix the autoupdatebranch Action #563

merged 1 commit into from
Oct 15, 2020

Conversation

chiedo
Copy link
Contributor

@chiedo chiedo commented Oct 15, 2020

When moving to shas for more security, it looks like we broke the Docker action.

This should get it working again. Ideally we move to a Sha somehow in the future but I'm unsure how to do that considering the unique format of this Action being served from Docker rather than GitHub.

Example of the Action breaking: https://github.com/github/docs/actions/runs/309155706/workflow

Check off the following:

  • All of the tests are passing.

@chiedo chiedo requested a review from a team as a code owner October 15, 2020 18:26
@JamesMGreene
Copy link
Member

Is it maybe that the Docker registry digest SHAs don't match the Git commit SHAs...? 🤷🏻‍♂️
https://docs.docker.com/engine/reference/commandline/pull/#pull-an-image-by-digest-immutable-identifier

I am admittedly not well-versed in Docker. 😕

Copy link
Member

@JamesMGreene JamesMGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as a revert to get things functioning again. 👍🏻

@chiedo chiedo merged commit 515a98b into main Oct 15, 2020
@chiedo chiedo deleted the fix-docker branch October 15, 2020 18:40
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* remove comment

* update

* add full url

* add slashes

* add full url

* finish broken internal doc links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants