-
Notifications
You must be signed in to change notification settings - Fork 60.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the color of the warning links #5781
Conversation
I suspect we want to change the background color of the banner instead of the link color. 🙏🏼 |
Hi, @heiskr! I tested it by changing the background color and it really got better. However, I am not allowed to make this change, since the What to do in this situation? |
I think the file you want to update is |
You're right, thanks. I include the necessary changes. |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
As reported in Issue #5349, the color of the link in the notices is unreadable due to the blue background.
I changed it to the color
-color-bg-info
of premier.style.With the change, it will look like this:
This will also affect documentation in Portuguese, Spanish and Japanese, in addition to Chinese.
Closes #5349.
What's being changed:
Check off the following: