Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen Dependency Requirements #25

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Loosen Dependency Requirements #25

merged 3 commits into from
Sep 27, 2023

Conversation

GrantBirki
Copy link
Member

@GrantBirki GrantBirki commented Sep 21, 2023

Loosen Dependency Requirements

This pull request loosens our dependency requirements so that Gems can play together nicely.

Right now, it is really difficult to bump a single gem in entitlements unless everything is running the proper versions.

Example:

$ bundle install
Resolving dependencies...
Could not find compatible versions

Because <redacted> >= 0.4.1 depends on entitlements-github-plugin = 0.4.1
  and Gemfile depends on entitlements-github-plugin = 0.4.2,
  <redacted> >= 0.4.1 cannot be used.
So, because Gemfile depends on <redacted> = 0.4.1,
  version solving has failed.

All of these peer dependencies making simple updates very cumbersome

@GrantBirki GrantBirki added the dependencies Pull requests that update a dependency file label Sep 21, 2023
@GrantBirki GrantBirki merged commit afbcaa4 into main Sep 27, 2023
7 checks passed
@GrantBirki GrantBirki deleted the fix-deps branch September 27, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants