feat: schedule and schedule day environment variables #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeridth
force-pushed
the
jm_add_schedule_env_var
branch
2 times, most recently
from
f8e0466
to
220a0b6
Compare
jmeridth
changed the title
jmeridth
force-pushed
the
jm_add_schedule_env_var
branch
from
220a0b6
to
6547db1
Compare
…ironment variables Closes github#217 - [x] new environment variables: SCHEDULE, SCHEDULE_DAY - [x] update README with new environment variable information - [x] passing specs Signed-off-by: jmeridth <jmeridth@gmail.com>
jmeridth
force-pushed
the
jm_add_schedule_env_var
branch
from
6547db1
to
edcc8c1
Compare
|
@zkoppert Should we encapsulate scheduling stuff in an object/class? I thought that too. This is a v0.1. but any additional scheduling items should be groups IMO. |
zkoppert
reviewed
Sep 16, 2024
Co-authored-by: Zack Koppert <zkoppert@github.com>
We can wait on an object/class for now. Happy to just get this through. |
switched from git-all to just git (pinned) Signed-off-by: jmeridth <jmeridth@gmail.com>
zkoppert
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #217
Pull Request
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
fix,documentation,enhancement,infrastructure,maintenanceorbreaking