Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated progressive web apps topic #173

Merged
merged 1 commit into from
Feb 16, 2018
Merged

Updated progressive web apps topic #173

merged 1 commit into from
Feb 16, 2018

Conversation

TalAter
Copy link
Contributor

@TalAter TalAter commented Feb 15, 2018

I am:

  • Suggesting edits to an existing Topic page
  • Curating a new Topic page

EDITING AN EXISTING TOPIC PAGE*

I'm suggesting these edits to an existing topic:

  • Image (and my file is *.png, square, dimensions 288x288)
  • Content (and my changes are in index.md)

Please explain why these changes are necessary:

As someone who has been involved with the creation of progressive web apps since day one (I wrote the O'Reilly book Building Progressive Web Apps), I think the current topic needs two changes:

  • Remove the created_by field which only listed two people as the creators of progressive web apps. While Francis and Alex were immensely influential for the creation of progressive web apps and service workers in particular, and while I personally adore and have been floored by the depth of Alex's intelligence and vision in every single interaction I ever had with him (I never had a chance to meet Francis), I think it isn't fair to attribute to two people what is an industry-wide effort by dozens of people who have worked day and night to make this happen.

  • I would also suggest replacing the link to Google's web site (which seems to suggest it is the "official website" of progressive web apps) with a link maintained by many different browser vendors (such as MDN). Again, while I absolutely admire Google's efforts to help further the open Web, and believe they have been one of (if not the most) critical elements in making progressive web apps a success, this was an industry wide effort with a lot of resources put in by many companies. If anything, the appearance of progressive web apps being a Google thing has been detrimental to their adoption.

CURATING A NEW TOPIC PAGE

  • I've formatted my changes as a new folder directory, named for the topic as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please explain why you think this Topic page should be curated:

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

As someone who has been involved with the creation of progressive web apps since day one (I wrote the O'Reilly book [Building Progressive Web Apps](https://pwabook.com)), I think the current topic needs two changes:

- Remove the `created_by` field which only listed two people as the creators of progressive web apps. While Francis and Alex were immensely influential for the creation of progressive web apps and service workers in particular, and while I personally adore and have been floored by the depth of Alex's intelligence and vision in every single interaction I ever had with him (I never had a chance to meet Francis), I think it isn't fair to attribute to two people what is an industry-wide effort by dozens of people who have worked day and night to make this happen.

- I would also suggest replacing the link to Google's web site (which seems to suggest it is the "official website" of progressive web apps) with a link maintained by many different browser vendors (such as MDN). Again, while I absolutely admire Google's efforts to help further the open Web, and believe they have been one of (if not the most) critical elements in making progressive web apps a success, this was an industry wide effort with a lot of resources put in by many companies. If anything, the appearance of progressive web apps being a Google thing has been detrimental to their adoption.
@TalAter TalAter mentioned this pull request Feb 15, 2018
8 tasks
@MikeMcQuaid
Copy link
Contributor

Seems reasonable.
Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @TalAter!

@MikeMcQuaid MikeMcQuaid merged commit 414ce80 into github:master Feb 16, 2018
@TalAter TalAter deleted the patch-1 branch February 17, 2018 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants