Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export tone modifiers #68

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Export tone modifiers #68

merged 1 commit into from
Aug 23, 2024

Conversation

marywhite
Copy link
Contributor

Goal

This PR exports the applyTone and removeTone functions used for modifying an emoji character. This allows to to programmatically retrieve the value of the tone-adjusted emoji without needing to query to DOM for <g-emoji> text content.

This supports https://github.com/github/issues/issues/8264

@marywhite marywhite requested a review from a team as a code owner August 23, 2024 14:27
@marywhite marywhite self-assigned this Aug 23, 2024
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@camertron camertron merged commit ae29f13 into main Aug 23, 2024
3 checks passed
@camertron camertron deleted the marywhite/expose-tone-modifiers branch August 23, 2024 18:46
@camertron
Copy link
Contributor

Published in v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants