-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate release process for ospo-actions #78
Comments
@zkoppert/@ahpook before I fill out the description above, does this issue mean we will automate releases when PRs merge or is release management still manual? If automated, I'd like to introduce an issue and pull request to require PRs have labels so that they are categorized in the release. If we automate and don't do that, then some PRs will be uncategorized (accidentally). If this is just about automating the Action container images and releases are still manual, then I can write the description up that way. Both paths I will summarize the GitHub Action I plan to create to handle the image creation and pushing after a release. Thank you. |
Personally, I'd prefer it to be fully automated meaning automate a release each time a PR is merged to main. Requiring one of the labels in our set of supported labels would be great! |
Awesome. Thank you. Will get description updated and ask for feedback. |
Thinking about this more last night, I'd very much be a fan of using the
We can then use the Auto Labeler feature of the pre-releaser GHA to use regex based on the PR prefixes to auto label the PRs. A side benefit is that, as a maintainer, you can look at the repo's pull requests and easily see what type they are based on the prefix and the auto labelling. Full disclosure: we use this for argo-helm in the argoproj org. It works well. There can be a little frustration by first-time contributors on how to get the titles correct, but our error messaging gave clarity to help them. |
The pre-releaser GitHub Action can still be used. It has a boolean |
If we are adding friction for first time contributors lets just make sure we spell everything out in our contributing docs and continue to be responsive in issues and PRs. Sounds like a great plan! |
A nice aspect of PR titles imo is that they can also be adjusted by maintainers of a repo i.e. us, so we can help/"just fix it" for contributors if they get it wrong and don't necessarily have to go through a back and forth cycle with them. |
+1 to this take. I'm a big fan of keeping things labeled / organized, but those standards will need to be clearly articulated in the docs and perhaps some hints added to the PR / Issue templates directly, in case contributors skip the README / CONTRIBUTORS.md 🙂 |
Part of github/github-ospo#78 - [x] lint pr title adhering to conventional commits (helps with auto labelling) - [x] Update CONTRIBUTING.md - [x] automated releases - [x] how to file a bug report - [x] how to file an enhancement - [x] Update pull_request_template with new standard - [x] setup autolabelling through release-drafter github action config - [x] create auto-labeler workflow - [x] change release-drafter workflow to release - [x] create release, including new tag - [x] create discussion announcement based on release - [x] build container images, tag them and release them Manual Actions: - [x] create `revert` and `maintenance` labels - [x] put repository and category IDs into secrets for the discussion create action Signed-off-by: jmeridth <jmeridth@gmail.com>
Part of github/github-ospo#78 - [x] lint pr title adhering to conventional commits (helps with auto labelling) - [x] Update CONTRIBUTING.md - [x] automated releases - [x] how to file a bug report - [x] how to file an enhancement - [x] Update pull_request_template with new standard - [x] setup autolabelling through release-drafter github action config - [x] create auto-labeler workflow - [x] change release-drafter workflow to release - [x] create release, including new tag - [x] create discussion announcement based on release - [x] build container images, tag them and release them Manual Actions: - [x] create `revert` and `maintenance` labels - [x] put repository and category IDs into secrets for the discussion create action Signed-off-by: jmeridth <jmeridth@gmail.com>
Part of github/github-ospo#78 - [x] lint pr title adhering to conventional commits (helps with auto labelling) - [x] Update CONTRIBUTING.md - [x] automated releases - [x] how to file a bug report - [x] how to file an enhancement - [x] Update pull_request_template with new standard - [x] setup autolabelling through release-drafter github action config - [x] create auto-labeler workflow - [x] change release-drafter workflow to release - [x] create release, including new tag - [x] create discussion announcement based on release - [x] build container images, tag them and release them Manual Actions: - [x] create `revert` and `maintenance` labels - [x] put repository and category IDs into secrets for the discussion create action Signed-off-by: jmeridth <jmeridth@gmail.com>
Part of github/github-ospo#78 - [x] lint pr title adhering to conventional commits (helps with auto labelling) - [x] Update CONTRIBUTING.md - [x] automated releases - [x] how to file a bug report - [x] how to file an enhancement - [x] Update pull_request_template with new standard - [x] setup autolabelling through release-drafter github action config - [x] create auto-labeler workflow - [x] change release-drafter workflow to release - [x] create release, including new tag - [x] create discussion announcement based on release - [x] build container images, tag them and release them Manual Actions: - [x] create `revert` and `maintenance` labels - [x] put repository and category IDs into secrets for the discussion create action Signed-off-by: jmeridth <jmeridth@gmail.com>
Part of github/github-ospo#78 - [x] lint pr title adhering to conventional commits (helps with auto labelling) - [x] Update CONTRIBUTING.md - [x] automated releases - [x] how to file a bug report - [x] how to file an enhancement - [x] Update pull_request_template with new standard - [x] setup autolabelling through release-drafter github action config - [x] create auto-labeler workflow - [x] change release-drafter workflow to release - [x] create release, including new tag - [x] create discussion announcement based on release - [x] build container images, tag them and release them Manual Actions: - [x] create `revert` and `maintenance` labels - [x] put repository and category IDs into secrets for the discussion create action Signed-off-by: jmeridth <jmeridth@gmail.com>
Part of github/github-ospo#78 - [x] lint pr title adhering to conventional commits (helps with auto labelling) - [x] Update CONTRIBUTING.md - [x] automated releases - [x] how to file a bug report - [x] how to file an enhancement - [x] Update pull_request_template with new standard - [x] setup autolabelling through release-drafter github action config - [x] create auto-labeler workflow - [x] change release-drafter workflow to release - [x] create release, including new tag - [x] create discussion announcement based on release - [x] build container images, tag them and release them Manual Actions: - [x] create `revert` and `maintenance` labels - [x] put repository and category IDs into secrets for the discussion create action Signed-off-by: jmeridth <jmeridth@gmail.com>
Part of github/github-ospo#78 - [x] lint pr title adhering to conventional commits (helps with auto labelling) - [x] Update CONTRIBUTING.md - [x] automated releases - [x] how to file a bug report - [x] how to file an enhancement - [x] Update pull_request_template with new standard - [x] setup autolabelling through release-drafter github action config - [x] create auto-labeler workflow - [x] change release-drafter workflow to release - [x] create release, including new tag - [x] create discussion announcement based on release - [x] build container images, tag them and release them Manual Actions: - [x] create `revert` and `maintenance` labels - [x] put repository and category IDs into secrets for the discussion create action Signed-off-by: jmeridth <jmeridth@gmail.com>
Part of github/github-ospo#78 - [x] lint pr title adhering to conventional commits (helps with auto labelling) - [x] Update CONTRIBUTING.md - [x] automated releases - [x] how to file a bug report - [x] how to file an enhancement - [x] Update pull_request_template with new standard - [x] setup autolabelling through release-drafter github action config - [x] create auto-labeler workflow - [x] change release-drafter workflow to release - [x] create release, including new tag - [x] create discussion announcement based on release - [x] build container images, tag them and release them Manual Actions: - [x] create `revert` and `maintenance` labels - [x] put repository and category IDs into secrets for the discussion create action Signed-off-by: jmeridth <jmeridth@gmail.com>
This is complete |
Current:
Desired:
The text was updated successfully, but these errors were encountered: