Add support for Cake.Net #2107
Merged
Add support for Cake.Net #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cake.Net creates a tools folder at the root which contains downloaded packages and should not be checked in.
shiftkey
reviewed
Sep 16, 2016
| @@ -263,3 +263,6 @@ paket-files/ | |||
| # Python Tools for Visual Studio (PTVS) | |||
| __pycache__/ | |||
| *.pyc | |||
|
|
|||
| # Cake | |||
| tools/ | |||
There was a problem hiding this comment.
I can't help but feel this is too broad a rule, and might catch other things.
For example, FAKE uses a .fake/ path for it's local cache.
There was a problem hiding this comment.
I agree it is a possibility. There are a few of these folders in there already e.g. artifacts/ publish/. Cake is now part of the .NET Foundation and growing in popularity. This PR can go either way.
There was a problem hiding this comment.
Perhaps we could have this commented out by default, so that users can opt-in to the change...
|
@RehanSaeed thanks! |
nitinkgp23
pushed a commit
to nitinkgp23/gitignore
that referenced
this pull request
Oct 8, 2016
Add support for Cake.Net
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cake.Net creates a tools folder at the root which contains downloaded packages and should not be checked in. See documentation for reference to the tools folder where NuGet packages are downloaded.