Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename package from expression to spdxexp #27

Merged
merged 1 commit into from
Dec 1, 2022
Merged

rename package from expression to spdxexp #27

merged 1 commit into from
Dec 1, 2022

Conversation

elrayle
Copy link
Collaborator

@elrayle elrayle commented Dec 1, 2022

Thoughts on the renaming:

  • expression is long for a go package name
  • exp is not specific (e.g. exp.Satisfies)
  • spdxexp hits the balance between short length and enough info to quickly distinguish it from other packages (e.g. spdxexp.Satisfies)

@elrayle
rename package from expression to spdxexp
9374645 
Thoughts on the renaming:
- expression is long for a go package name
- exp is not specific (e.g. exp.Satisfies)
- spdxexp hits the balance between short length and enough info to quickly distinguish it from other packages (e.g. spdxexp.Satisfies)
@elrayle elrayle requested a review from ajhenry as a code owner December 1, 2022 16:09
dangoor
dangoor approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@dangoor dangoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change and seems fine!

@elrayle elrayle merged commit cf11334 into main Dec 1, 2022
@elrayle elrayle deleted the elr/refactor-to-spdxexp branch December 1, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangoor dangoor dangoor approved these changes

@ajhenry ajhenry Awaiting requested review from ajhenry ajhenry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elrayle @dangoor