improve checking for syntax errors #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #4 The issue suggested fixing this at the scan level, but scan is just a tokenizer. Parse knows what is expected syntactically. The fix was made at the parse level and tests for malformed expressions were added.
elrayle
force-pushed
the
elr/paren-bug
branch
from
c71f95f
to
a83a0a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4
The issue suggested fixing this at the scan level, but scan is just a tokenizer. Parse knows what is expected syntactically. Tests were added for various malformed expressions. The fix was made at the parse level in multiple places and included if possible better error messages for what went wrong.