Make NormalizedHotkeyString
extend NormalizedSequenceString
#106
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
HotkeyString
is a validSequenceString
but with only one item in the sequence. So anything that acceptsSequenceString
should also acceptHotkeyString
.This PR makes
HotkeyString
extendSequenceString
to allow for this.This felt a little backwards to me because sequences are built from hotkeys, not the other way around, but it is correct. I made a simple demo to test it out:
Note
Using string template types for this would solve this problem more elegantly, but that's a lot more complicated and comes with more of a compile-time performance cost. This is 'good enough'.