Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to compiled JS files in examples #21

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Conversation

notlmn
Copy link
Contributor

@notlmn notlmn commented Jul 7, 2019

Updated links to compiled JS files in the examples file to make them work when deploying to GitHub Pages.

The links in these files were updated in c613f66, but that doesn't work for when testing online version deployed to GitHub pages as the directory doesn't exit.

Also added a comment to tell the user to change the links to point to a local version when testing locally.

Copy link
Contributor

@muan muan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

examples/index.html Outdated Show resolved Hide resolved
examples/polyfill.html Outdated Show resolved Hide resolved
@notlmn
Copy link
Contributor Author

notlmn commented Jul 21, 2019

Done!

Copy link
Contributor

@muan muan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@muan muan merged commit 8809470 into github:master Jul 22, 2019
@notlmn notlmn deleted the fix-examples branch July 22, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants