Fix up types for cached and returned data. #84
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.#getData()
had the typePromise<string>
, but this is inaccurate. It could also return:string
Error
This all sort of stems from the
privateData
Map
, which did not have template types.This PR adds an
async
keyword to avoid the first case, and adds additional types for the second case. This has consequences across quite a few methods, so I've split the PR out from #81 for separate discussion.