Add heading increment rule #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khiga8
commented
Dec 22, 2022
| @@ -4,8 +4,9 @@ | |||
| "no-duplicate-header": true, | |||
| "no-emphasis-as-header": true, | |||
| "no-generic-link-text": true, | |||
| "no-heading-increment": true, | |||
| "no-space-in-links": false, | |||
There was a problem hiding this comment.
@andrialexandrou I am curious about why this "no-space-in-links" rule is part of accessibility and is false.
There was a problem hiding this comment.
Thanks for looking into these. I'll need some time to get my head back into this space and revisit the reasoning.
|
👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.
|
JoyceZhu
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heading-increment is an accessibility rule and should be surfaced in
accessibility.json.