Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library structure #25

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Update library structure #25

merged 1 commit into from
Dec 27, 2022

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Dec 23, 2022

Fixes: #24

Currently all the source files live at the root of the repo.
I think it'll be beneficial to place the source files in src with a proper home for rules.

I propose a file structure like the following to start with:

src
--rules
----no-default-alt-text.js
----no-generic-link-text.js
----index.js
--helpers
test
--utils
--no-default-alt-text.test.js
--no-generic-link-text.test.js
docs
--rules
package.json
index.js
README.md

@khiga8 khiga8 requested a review from a team as a code owner December 23, 2022 15:48
@accessibility-bot
Copy link
Collaborator

👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos (with description following) demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

Copy link
Contributor

@JoyceZhu JoyceZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me!

@khiga8 khiga8 merged commit ccf8f37 into main Dec 27, 2022
@khiga8 khiga8 deleted the kh-change-library-structure branch December 28, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-organize repo structure
3 participants