Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alt text rule to flag image or Image #28

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Dec 28, 2022

After #26 is merged, rebase and merge.

Fixes: #23

This PR updates the no-default-alt-text rule, which currently only flags the macOS default screenshot name, to flag Image and image as alt text. Accordingly, it updates the lint rule description to be more broad.

@khiga8 khiga8 requested a review from a team as a code owner December 28, 2022 15:34
@accessibility-bot
Copy link
Collaborator

👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos (with description following) demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

@khiga8 khiga8 changed the base branch from kh-introduce-docs-folder to main December 28, 2022 16:18
@khiga8
Copy link
Contributor Author

khiga8 commented Dec 28, 2022

If #26 has not been merged, review just 38434ce!

Copy link
Contributor

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@khiga8 khiga8 merged commit 602efc3 into main Dec 28, 2022
@khiga8 khiga8 deleted the kh-update-alt-text-rule branch December 28, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag image, Image usage as alt text
3 participants