Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a code sample with more context for package.json #44

Merged
merged 1 commit into from
May 15, 2023

Conversation

sampart
Copy link
Contributor

@sampart sampart commented May 12, 2023

For developers who don't normally work on node projects, just having the command to invoke doesn't provide enough context as to how to update package.json. This change provides a fuller example with more context.

For developers who don't normally work on node projects, just having the command to invoke doesn't provide enough context as to how to update `package.json`. This change provides a fuller example with more context.
@sampart sampart requested a review from a team as a code owner May 12, 2023 10:31
@sampart sampart requested a review from its-mia May 12, 2023 10:31
@accessibility-bot
Copy link
Collaborator

👋 Hello and thanks for pinging us! You've entered our first responder queue. An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos (with description following) demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

Copy link
Contributor

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙌!

@sampart sampart merged commit 83a3eb2 into main May 15, 2023
@sampart sampart deleted the fuller-scripts-example branch May 15, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants