Skip to content

Commit

Permalink
Remove version lock from html-proofer
Browse files Browse the repository at this point in the history
There have been 2 major revs of HTML-Proofer since the one
we pinned. The current one is causing flaky tests - it's missing
clear errors w/internal links and only reports the first
error it finds rather than running to completion and reporting
all of them.

The latest version (5.0.8 at the moment) does catch all of the
errors but has a problem locally where UTF-8 encoded anchor links
are not properly decoded. This might be a problem local to me though;
I coded up a spec test in html-proofer with an exact copy-paste
of one of the failing links and ... it passes there.

So i'll unpin this and see if there's some local gem issue that's
causing this on my machine and maybe it works in the Actions env.
  • Loading branch information
ahpook committed Apr 29, 2024
1 parent 9ce4c18 commit 7d2578b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ source "https://rubygems.org"
gem "github-pages", group: :jekyll_plugins

group :test do
gem "html-proofer", "~> 3.19.4"
gem "html-proofer"
gem "rake"
end

0 comments on commit 7d2578b

Please sign in to comment.