Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hindi #3084

Closed
wants to merge 11 commits into from
Closed

Hindi #3084

wants to merge 11 commits into from

Conversation

jamestitus299
Copy link
Contributor

@jamestitus299 jamestitus299 commented Sep 1, 2023

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


@jamestitus299 jamestitus299 requested a review from a team as a code owner September 1, 2023 09:34
@jamestitus299 jamestitus299 temporarily deployed to Pages Preview September 1, 2023 09:35 — with GitHub Actions Inactive
@jamestitus299
Copy link
Contributor Author

Checking 344 external links...

I am getting this error. What should I do?

HTML-Proofer found 8 failures!

@ahpook
Copy link
Contributor

ahpook commented Sep 2, 2023

Hello @jamestitus299 , thank you for the contributions! Is this PR the one to use instead of #3083 ?

The errors you're seeing are because the internal links that use the ../page/#anchor-name syntax are still using the English names for the headers that they will link to. I think you can change those links to use the Hindi names, like this example from the Korean translation:

[ 수 있도록 [즉각 대응](../building-community/#악당에게-관용을-베풀지-마세요)  

@jamestitus299 jamestitus299 temporarily deployed to Pages Preview September 2, 2023 04:15 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants