Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking to internal hash #3130

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

olsza
Copy link
Contributor

@olsza olsza commented Oct 11, 2023

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


I've noticed that in PR they often don't pass the tests....
I checked and corrected it :)

image

@olsza olsza marked this pull request as ready for review October 11, 2023 08:20
@olsza olsza requested a review from a team as a code owner October 11, 2023 08:20
Copy link
Contributor

@ipc103 ipc103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thanks so much for the contribution! I'm not sure when these started failing, but I'll merge this to unblock

@ipc103 ipc103 added this pull request to the merge queue Oct 11, 2023
Merged via the queue into github:main with commit facbd82 Oct 11, 2023
3 checks passed
@olsza
Copy link
Contributor Author

olsza commented Oct 11, 2023

❤️ Thanks so much for the contribution! I'm not sure when these started failing, but I'll merge this to unblock

I will monitor this...in general I have seen that it has been going on for a very long time, about a year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants