Disable DNS Result Caching #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snh I corrected the failing Rubocop offenses on |
benbalter
approved these changes
Jun 8, 2018
benbalter
reviewed
Jun 8, 2018
| @@ -6,7 +6,8 @@ class Resolver | |||
| DEFAULT_RESOLVER_OPTIONS = { | |||
| :retry_times => 2, | |||
| :query_timeout => 5, | |||
| :dnssec => false | |||
| :dnssec => false, | |||
| :do_caching => false | |||
There was a problem hiding this comment.
Obviously nothing we can do about it, but just wanted to note that do_caching is a silly flag name. 😄
|
@snh You're the bomb dot com, thank you! Great sleuthing. 🔍 @benbalter thanks for the quick review on this too! ❤️ |
parkr
approved these changes
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dnsruby by default appears to cache results internally, which prevents the redundant checking functionality as implemented in #90 and #98 from performing as expected.
In particular, the earlier cached entries from the default nameservers are returned when later trying the authoritative and public nameservers.
This PR disables this caching in Dnsruby.
While rudimentary, I was able to test this was effective by performing the following two queries in
script/console, spaced sufficiently apart to be able to determine by the returned TTLs that they were not sharing a local cached entry:Without this fix, it is obvious that they are sharing the same cache entry, as the results from these two queries return TTLs that align perfectly.