Escape specific html tags in P elements when quoting to markdown #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akenneth
changed the title
|
I wasn't sure if I should bump the version in package.json (and if there are any other steps in order to publish this once it is accepted) |
anleac
reviewed
Aug 4, 2021
anleac
approved these changes
Aug 4, 2021
|
No need to bump the version, I can do that when I release it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small fix to support escaping html tags inside a P element when converting to markdown.
Before this change if a text contained an escaped html tag like:
<pre> Hello </pre>
It would be quoted as
See the before and after in this image, where the top comment is the one being quoted.
Notice how the middle comment (before this change) wrongfully converts
<pre> nothing </pre>into a highlighted part with only the textnothingin it:I decided to match for a specific list of tags
pre|strong|weak|emfor now in order to minimize the risk of this capturing some things it shouldn't.Please let me know if any other tags should be added here.