Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RelativeTime: Support custom format #123

Closed
wants to merge 2 commits into from
Closed

RelativeTime: Support custom format #123

wants to merge 2 commits into from

Conversation

nomego
Copy link
Contributor

@nomego nomego commented Aug 13, 2019

Allow user to supply a strftime() format through the format
attribute, to be used when outside the relative time scope.

Patrik Kullman and others added 2 commits August 13, 2019 11:37
RelativeTime: Support custom format
c2037ad 
Allow user to supply a strftime() format through the format
attribute, to be used when outside the relative time scope.
@dotpointer
Merge branch 'master' into custom-format
a64e63a
@tobyzerner
Copy link

Any chance of this getting merged?

@keithamus keithamus changed the base branch from master to main August 3, 2020 15:32
@bankoViktor
Copy link

Can we expect action in the near future on this issue?

keithamus
keithamus approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍

Some tests would be nice to confirm this behavior, but otherwise I think this is a worthwhile changes.

/cc @github/ui-frameworks for a second review

koddsson
koddsson approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, tests would be great. We've missed this PR for quite some time so it needs some rebasing but otherwise this LGTM

This was referenced Oct 18, 2022
Closed
Merged
@keithamus
Copy link
Member

keithamus commented Oct 18, 2022 •
edited
Loading

This was merged in via #177, thanks for working on this @nomego! I'll get a release out with a few other improvements this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koddsson koddsson koddsson approved these changes

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nomego @tobyzerner @bankoViktor @keithamus @koddsson @dotpointer