Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch element to defining content within ShadowDOM #193

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Switch element to defining content within ShadowDOM #193

merged 1 commit into from
Nov 2, 2022

Conversation

keithamus
Copy link
Member

This changes the <relative-time> element to use a ShadowRoot, instead of mutating the textContent directly. This is useful because it enables <relative-time> to mutate its own display without interfering with components or frameworks which assess or otherwise depend on the tree below <relative-time>; for example frameworks like React which maintain a virtual DOM, or code which leverages Mutation Observers to track changes to the tree.

The trade-off here is that it is not possible to assert the display of the date via el.textContent, as this would represent the light HTML tree (so likely the original date rendered server side). Consequently the tests need to change to accommodate this.

@keithamus keithamus requested a review from a team as a code owner November 2, 2022 16:24
koddsson
koddsson approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

src/relative-time-element.ts
@@ -256,6 +256,11 @@ export default class RelativeTimeElement extends HTMLElement implements Intl.Dat
this.datetime = value?.toISOString() || ''
}

constructor() {
super()
if (!this.shadowRoot) this.attachShadow({mode: 'open'})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the guard for declarative shadow doms! <3

@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • ⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@keithamus keithamus merged commit 7bcc8a1 into main Nov 2, 2022
@keithamus keithamus deleted the use-shadowdom branch November 3, 2022 11:58
andrewpollock referenced this pull request in google/osv.dev Nov 29, 2022
@renovate-bot
Update appengine-frontend (#802)
3689aba 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@github/time-elements](https://togithub.com/github/time-elements) |
[`3.1.4` ->
`3.6.0`](https://renovatebot.com/diffs/npm/@github%2ftime-elements/3.1.4/3.6.0)
|
[![age](https://badges.renovateapi.com/packages/npm/@github%2ftime-elements/3.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@github%2ftime-elements/3.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@github%2ftime-elements/3.6.0/compatibility-slim/3.1.4)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@github%2ftime-elements/3.6.0/confidence-slim/3.1.4)](https://docs.renovatebot.com/merge-confidence/)
|
| [css-loader](https://togithub.com/webpack-contrib/css-loader) |
[`6.7.1` ->
`6.7.2`](https://renovatebot.com/diffs/npm/css-loader/6.7.1/6.7.2) |
[![age](https://badges.renovateapi.com/packages/npm/css-loader/6.7.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/css-loader/6.7.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/css-loader/6.7.2/compatibility-slim/6.7.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/css-loader/6.7.2/confidence-slim/6.7.1)](https://docs.renovatebot.com/merge-confidence/)
|
| [highlight.js](https://highlightjs.org/)
([source](https://togithub.com/highlightjs/highlight.js)) | [`11.6.0` ->
`11.7.0`](https://renovatebot.com/diffs/npm/highlight.js/11.6.0/11.7.0)
|
[![age](https://badges.renovateapi.com/packages/npm/highlight.js/11.7.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/highlight.js/11.7.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/highlight.js/11.7.0/compatibility-slim/11.6.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/highlight.js/11.7.0/confidence-slim/11.6.0)](https://docs.renovatebot.com/merge-confidence/)
|
| [lit](https://lit.dev/) ([source](https://togithub.com/lit/lit)) |
[`2.4.0` -> `2.4.1`](https://renovatebot.com/diffs/npm/lit/2.4.0/2.4.1)
|
[![age](https://badges.renovateapi.com/packages/npm/lit/2.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/lit/2.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/lit/2.4.1/compatibility-slim/2.4.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/lit/2.4.1/confidence-slim/2.4.0)](https://docs.renovatebot.com/merge-confidence/)
|
|
[mini-css-extract-plugin](https://togithub.com/webpack-contrib/mini-css-extract-plugin)
| [`2.6.1` ->
`2.7.0`](https://renovatebot.com/diffs/npm/mini-css-extract-plugin/2.6.1/2.7.0)
|
[![age](https://badges.renovateapi.com/packages/npm/mini-css-extract-plugin/2.7.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/mini-css-extract-plugin/2.7.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/mini-css-extract-plugin/2.7.0/compatibility-slim/2.6.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/mini-css-extract-plugin/2.7.0/confidence-slim/2.6.1)](https://docs.renovatebot.com/merge-confidence/)
|
| [sass](https://togithub.com/sass/dart-sass) | [`1.55.0` ->
`1.56.1`](https://renovatebot.com/diffs/npm/sass/1.55.0/1.56.1) |
[![age](https://badges.renovateapi.com/packages/npm/sass/1.56.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/sass/1.56.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/sass/1.56.1/compatibility-slim/1.55.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/sass/1.56.1/confidence-slim/1.55.0)](https://docs.renovatebot.com/merge-confidence/)
|
| [webpack](https://togithub.com/webpack/webpack) | [`5.74.0` ->
`5.75.0`](https://renovatebot.com/diffs/npm/webpack/5.74.0/5.75.0) |
[![age](https://badges.renovateapi.com/packages/npm/webpack/5.75.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/webpack/5.75.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/webpack/5.75.0/compatibility-slim/5.74.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/webpack/5.75.0/confidence-slim/5.74.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>github/time-elements</summary>

###
[`v3.6.0`](https://togithub.com/github/relative-time-element/releases/tag/v3.6.0)

[Compare
Source](https://togithub.com/github/time-elements/compare/v3.5.2...v3.6.0)

#### What's Changed

- add JSX IntrinsicElement types by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/214](https://togithub.com/github/relative-time-element/pull/214)

**Full Changelog**:
github/relative-time-element@v3.5.2...v3.6.0

###
[`v3.5.2`](https://togithub.com/github/relative-time-element/releases/tag/v3.5.2)

[Compare
Source](https://togithub.com/github/time-elements/compare/v3.5.1...v3.5.2)

#### What's Changed

- avoid updating during update call by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/215](https://togithub.com/github/relative-time-element/pull/215)
- Switch to promise batching on attributechangedcallback by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/216](https://togithub.com/github/relative-time-element/pull/216)

**Full Changelog**:
github/relative-time-element@v3.5.1...v3.5.2

###
[`v3.5.1`](https://togithub.com/github/relative-time-element/releases/tag/v3.5.1)

[Compare
Source](https://togithub.com/github/time-elements/compare/v3.5.0...v3.5.1)

#### What's Changed

- fix typo in observed attributes by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/212](https://togithub.com/github/relative-time-element/pull/212)

**Full Changelog**:
github/relative-time-element@v3.5.0...v3.5.1

###
[`v3.5.0`](https://togithub.com/github/relative-time-element/releases/tag/v3.5.0)

[Compare
Source](https://togithub.com/github/time-elements/compare/v3.4.1...v3.5.0)

#### What's Changed

This release moves define calls into separate files, allowing import of
each element without triggering the custom element definition. In
addition it attempts to safely use globals so that it can be imported
into NodeJS without error.

- move customElements define calls to index.js and refactor by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/209](https://togithub.com/github/relative-time-element/pull/209)
- Ensure HTMLElement exists in all contexts by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/211](https://togithub.com/github/relative-time-element/pull/211)
- add `define` export for custom element registration by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/210](https://togithub.com/github/relative-time-element/pull/210)

**Full Changelog**:
github/relative-time-element@v3.4.1...v3.5.0

###
[`v3.4.1`](https://togithub.com/github/relative-time-element/releases/tag/v3.4.1)

[Compare
Source](https://togithub.com/github/time-elements/compare/v3.4.0...v3.4.1)

#### What's Changed

- use `Intl` without window prefix by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/208](https://togithub.com/github/relative-time-element/pull/208)

**Full Changelog**:
github/relative-time-element@v3.4.0...v3.4.1

###
[`v3.4.0`](https://togithub.com/github/relative-time-element/releases/tag/v3.4.0)

[Compare
Source](https://togithub.com/github/time-elements/compare/v3.3.0...v3.4.0)

#### What's Changed

- Strftime localisation by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/206](https://togithub.com/github/relative-time-element/pull/206)
- Add some localised dates as examples by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/207](https://togithub.com/github/relative-time-element/pull/207)

(Thanks [@&#8203;brunoprietog](https://togithub.com/brunoprietog) for
the bug report!)

**Full Changelog**:
github/relative-time-element@v3.3.0...v3.4.0

###
[`v3.3.0`](https://togithub.com/github/relative-time-element/releases/tag/v3.3.0)

[Compare
Source](https://togithub.com/github/time-elements/compare/v3.2.5...v3.3.0)

##### What's Changed

- add elapsed time format by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/204](https://togithub.com/github/relative-time-element/pull/204)

**Full Changelog**:
github/relative-time-element@v3.2.5...v3.3.0

###
[`v3.2.5`](https://togithub.com/github/relative-time-element/releases/tag/v3.2.5)

[Compare
Source](https://togithub.com/github/time-elements/compare/v3.2.4...v3.2.5)

#### What's Changed

- ensure invalid dates fallback to lightdom textcontent by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/203](https://togithub.com/github/relative-time-element/pull/203)

**Full Changelog**:
github/relative-time-element@v3.2.4...v3.2.5

###
[`v3.2.4`](https://togithub.com/github/relative-time-element/releases/tag/v3.2.4)

[Compare
Source](https://togithub.com/github/time-elements/compare/v3.2.3...v3.2.4)

#### What's Changed

- fix bug in Intl detection by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/201](https://togithub.com/github/relative-time-element/pull/201)

**Full Changelog**:
github/relative-time-element@v3.2.3...v3.2.4

###
[`v3.2.3`](https://togithub.com/github/relative-time-element/releases/tag/v3.2.3)

[Compare
Source](https://togithub.com/github/time-elements/compare/v3.2.2...v3.2.3)

#### What's Changed

- [add tests for realtime
updates](https://togithub.com/github/relative-time-element/commit/a3ffb11df16ae8d9d33874d3c2f346caac653424)
- [actually call update rather than just getting
it](https://togithub.com/github/relative-time-element/commit/a376de11b9f59799fc8c881ed97962d945c4ca65)

**Full Changelog**:
github/relative-time-element@v3.2.2...v3.2.3

###
[`v3.2.2`](https://togithub.com/github/relative-time-element/releases/tag/v3.2.2)

[Compare
Source](https://togithub.com/github/time-elements/compare/v3.2.1...v3.2.2)

#### What's Changed

- [ensure first observer is called at correct
time](https://togithub.com/github/relative-time-element/commit/e7c4e8d38c40dc3afe9d82448ca17f41f173aa9f)

**Full Changelog**:
github/relative-time-element@v3.2.1...v3.2.2

###
[`v3.2.1`](https://togithub.com/github/relative-time-element/releases/tag/v3.2.1)

[Compare
Source](https://togithub.com/github/time-elements/compare/v3.2.0...v3.2.1)

#### What's Changed

- avoid eagerly calling this.update() by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/200](https://togithub.com/github/relative-time-element/pull/200)

**Full Changelog**:
github/relative-time-element@v3.2.0...v3.2.1

###
[`v3.2.0`](https://togithub.com/github/relative-time-element/releases/tag/v3.2.0)

[Compare
Source](https://togithub.com/github/time-elements/compare/v3.1.4...v3.2.0)

#### What's Changed

This release includes a large rewrite of the component with many new
features that allow for fine-grained control over the display of the
date. Existing uses will work as they always have, but a set of new
attributes provide detailed control about how dates get rendered!

- Update README.md by
[@&#8203;josepmartins](https://togithub.com/josepmartins) in
[https://github.com/github/relative-time-element/pull/171](https://togithub.com/github/relative-time-element/pull/171)
- Fix closing tag for `time-until` in documentation by
[@&#8203;meduzen](https://togithub.com/meduzen) in
[https://github.com/github/relative-time-element/pull/172](https://togithub.com/github/relative-time-element/pull/172)
- move AOR to primer by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/173](https://togithub.com/github/relative-time-element/pull/173)
- fix lang on relative-time day ordering by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/175](https://togithub.com/github/relative-time-element/pull/175)
- Custom format by [@&#8203;keithamus](https://togithub.com/keithamus)
in
[https://github.com/github/relative-time-element/pull/177](https://togithub.com/github/relative-time-element/pull/177)
- switch from karma to web-test-runner by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/178](https://togithub.com/github/relative-time-element/pull/178)
- Use esbuild by [@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/179](https://togithub.com/github/relative-time-element/pull/179)
- Split strftime out by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/180](https://togithub.com/github/relative-time-element/pull/180)
- add tense to relative-time by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/181](https://togithub.com/github/relative-time-element/pull/181)
- simplify time-until/ago elements by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/182](https://togithub.com/github/relative-time-element/pull/182)
- Extract tostring from relative time into element by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/183](https://togithub.com/github/relative-time-element/pull/183)
- Add threshold by [@&#8203;keithamus](https://togithub.com/keithamus)
in
[https://github.com/github/relative-time-element/pull/184](https://togithub.com/github/relative-time-element/pull/184)
- Refactor relative time by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/github/relative-time-element/pull/185](https://togithub.com/github/relative-time-element/pull/185)
- Inline utilities only used in `<relative-time>` by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[https://github.com/github/relative-time-element/pull/186](https://togithub.com/github/relative-time-element/pull/186)
- Inline extended time element into relative time by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/187](https://togithub.com/github/relative-time-element/pull/187)
- add relative-time tests for local-time by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/188](https://togithub.com/github/relative-time-element/pull/188)
- add setters for all attributes by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/189](https://togithub.com/github/relative-time-element/pull/189)
- RelativeTimeElement: Progressive time update intervals by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/190](https://togithub.com/github/relative-time-element/pull/190)
- Add custome elements manifest by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/191](https://togithub.com/github/relative-time-element/pull/191)
- Switch element to defining content within ShadowDOM by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/193](https://togithub.com/github/relative-time-element/pull/193)
- Update readme by [@&#8203;keithamus](https://togithub.com/keithamus)
in
[https://github.com/github/relative-time-element/pull/192](https://togithub.com/github/relative-time-element/pull/192)
- Local time refactor by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/194](https://togithub.com/github/relative-time-element/pull/194)
- add tests for ponyfills by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/195](https://togithub.com/github/relative-time-element/pull/195)
- refactor relative-time to remove RelativeTimeFormat by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/196](https://togithub.com/github/relative-time-element/pull/196)
- inline utils functions by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/197](https://togithub.com/github/relative-time-element/pull/197)
- Make duration class by
[@&#8203;keithamus](https://togithub.com/keithamus) in
[https://github.com/github/relative-time-element/pull/198](https://togithub.com/github/relative-time-element/pull/198)
- Minor cleanups by [@&#8203;keithamus](https://togithub.com/keithamus)
in
[https://github.com/github/relative-time-element/pull/199](https://togithub.com/github/relative-time-element/pull/199)

#### New Contributors

- [@&#8203;josepmartins](https://togithub.com/josepmartins) made their
first contribution in
[https://github.com/github/relative-time-element/pull/171](https://togithub.com/github/relative-time-element/pull/171)
- [@&#8203;meduzen](https://togithub.com/meduzen) made their first
contribution in
[https://github.com/github/relative-time-element/pull/172](https://togithub.com/github/relative-time-element/pull/172)

**Full Changelog**:
github/relative-time-element@v3.1.4...v3.2.0

</details>

<details>
<summary>webpack-contrib/css-loader</summary>

###
[`v6.7.2`](https://togithub.com/webpack-contrib/css-loader/blob/HEAD/CHANGELOG.md#&#8203;672-httpsgithubcomwebpack-contribcss-loadercomparev671v672-2022-11-13)

[Compare
Source](https://togithub.com/webpack-contrib/css-loader/compare/v6.7.1...v6.7.2)

</details>

<details>
<summary>highlightjs/highlight.js</summary>

###
[`v11.7.0`](https://togithub.com/highlightjs/highlight.js/blob/HEAD/CHANGES.md#Version-1170)

[Compare
Source](https://togithub.com/highlightjs/highlight.js/compare/11.6.0...11.7.0)

New Grammars:

- added 3rd party LookML grammar to SUPPORTED_LANGUAGES [Josh Temple][]
- added 3rd party FunC grammar to SUPPORTED_LANGUAGES \[Nikita
Sobolev]\[]
- Added 3rd party Flix grammar to SUPPORTED_LANGUAGES [The Flix
Organisation][]
-   Added 3rd party RVT grammar to SUPPORTED_LANGUAGES [Sopitive][]

Grammars:

-   enh(scheme) add `scm` alias for Scheme [matyklug18][]
-   fix(typescript) patterns like `<T =` are not JSX [Josh Goebel][]
-   fix(bash) recognize the `((` keyword [Nick Chambers][]
-   enh(Ruby) misc improvements (kws, class names, etc)  [Josh Goebel][]
- fix(js) do not flag `import()` as a function, rather a keyword
[nathnolt][]
-   fix(bash) recognize the `((` keyword [Nick Chambers][]
-   fix(nix) support escaped dollar signs in strings [h7x4][]
-   enh(cmake) support bracket comments [Hirse][]
-   enh(java) add yield keyword to java [MBoegers][]
-   enh(java) add permits keyword to java [MBoegers][]
- fix(javascript/typescript) correct identifier matching when using
numbers [Lachlan Heywood][]

Improvements:

-   Documentation typo fix by [Eddymens][]

[matyklug18]: https://togithub.com/matyklug18

[Josh Goebel]: https://togithub.com/joshgoebel

[Josh Temple]: https://togithub.com/joshtemple

[nathnolt]: https://togithub.com/nathnolt

[Nick Chambers]: https://togithub.com/uplime

[h7x4]: https://togithub.com/h7x4

[Hirse]: https://togithub.com/Hirse

[The Flix Organisation]: https://togithub.com/flix

[MBoegers]: https://togithub.com/MBoegers

[Lachlan Heywood]: https://togithub.com/lachieh

[Eddymens]: https://togithub.com/eddymens

[Sopitive]: https://togithub.com/Sopitive

</details>

<details>
<summary>lit/lit</summary>

###
[`v2.4.1`](https://togithub.com/lit/lit/blob/HEAD/packages/lit/CHANGELOG.md#&#8203;241)

[Compare
Source](https://togithub.com/lit/lit/compare/lit@2.4.0...lit@2.4.1)

##### Patch Changes

- [#&#8203;3374](https://togithub.com/lit/lit/pull/3374)
[`bb098950`](https://togithub.com/lit/lit/commit/bb0989507f73f1e6d484199e3767eed39ebbaf22)
- Initializers added to subclasses are no longer improperly added to
superclass.

</details>

<details>
<summary>webpack-contrib/mini-css-extract-plugin</summary>

###
[`v2.7.0`](https://togithub.com/webpack-contrib/mini-css-extract-plugin/blob/HEAD/CHANGELOG.md#&#8203;270-httpsgithubcomwebpack-contribmini-css-extract-plugincomparev261v270-2022-11-16)

[Compare
Source](https://togithub.com/webpack-contrib/mini-css-extract-plugin/compare/v2.6.1...v2.7.0)

##### Features

- add function support for locals (loader)
([#&#8203;985](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/985))
([65519d0](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/65519d0701b3c5d60585468b8220159cbbfbe6b8))

#####
[2.6.1](https://togithub.com/webpack-contrib/mini-css-extract-plugin/compare/v2.6.0...v2.6.1)
(2022-06-15)

##### Bug Fixes

- do not attempt hot reloading when emit is false
([#&#8203;953](https://togithub.com/webpack-contrib/mini-css-extract-plugin/issues/953))
([b426f04](https://togithub.com/webpack-contrib/mini-css-extract-plugin/commit/b426f04961846991e8ca671c6a4d48e6a83a46c2))

</details>

<details>
<summary>sass/dart-sass</summary>

###
[`v1.56.1`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#&#8203;1561)

[Compare
Source](https://togithub.com/sass/dart-sass/compare/1.56.0...1.56.1)

##### Embedded Sass

- Importer results now validate that `contents` is actually a string and
whether
    `sourceMapUrl` is an absolute URL.

###
[`v1.56.0`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#&#8203;1560)

[Compare
Source](https://togithub.com/sass/dart-sass/compare/1.55.0...1.56.0)

- **Potentially breaking change:** To match the CSS spec, SassScript
expressions
beginning with `not` or `(` are no longer supported at the beginning of
    parenthesized sections of media queries. For example,

    ```scss
    @&#8203;media (width >= 500px) and (not (grid))
    ```

    will now be emitted unchanged, instead of producing

    ```scss
    @&#8203;media (width >= 500px) and (false)
    ```

See [the Sass website](https://sass-lang.com/d/media-logic) for details.

- **Potentially breaking bug fix:** Angle units like `rad` or `turn` are
now
    properly converted to equivalent `deg` values for `hsl()`, `hsla()`,
    `adjust-hue()`, `color.adjust()`, and `color.change()`.

See [the Sass website](https://sass-lang.com/d/function-units#hue) for
    details.

- Fix indentation for selectors that span multiple lines in a `@media`
query.

- Emit a deprecation warning when passing `$alpha` values with units to
`color.adjust()` or `color.change()`. This will be an error in Dart Sass
    2.0.0.

See [the Sass website](https://sass-lang.com/d/function-units#alpha) for
    details.

- Emit a deprecation warning when passing a `$weight` value with no
units or
with units other than `%` to `color.mix()`. This will be an error in
Dart Sass
    2.0.0.

See [the Sass website](https://sass-lang.com/d/function-units#weight)
for
    details.

- Emit a deprecation warning when passing `$n` values with units to
`list.nth()`
    or `list.set-nth()`. This will be an error in Dart Sass 2.0.0.

See [the Sass website](https://sass-lang.com/d/function-units#index) for
    details.

- Improve existing deprecation warnings to wrap `/`-as-division
suggestions in
    `calc()` expressions.

- Properly mark the warning for passing numbers with units to `random()`
as a
    deprecation warning.

- Fix a bug where `@extend` could behave unpredicatably when used along
with
`meta.load-css()` and shared modules that contained no CSS themselves
but
    loaded CSS from other modules.

##### Dart API

-   Emit a deprecation warning when passing a `sassIndex` with units to
`Value.sassIndexToListIndex()`. This will be an error in Dart Sass
2.0.0.

##### JS API

- Importer results now validate whether `contents` is actually a string
type.

-   Importer result argument errors are now rendered correctly.

</details>

<details>
<summary>webpack/webpack</summary>

###
[`v5.75.0`](https://togithub.com/webpack/webpack/releases/tag/v5.75.0)

[Compare
Source](https://togithub.com/webpack/webpack/compare/v5.74.0...v5.75.0)

### Bugfixes

-   `experiments.*` normalize to `false` when opt-out
-   avoid `NaN%`
-   show the correct error when using a conflicting chunk name in code
-   HMR code tests existance of `window` before trying to access it
-   fix `eval-nosources-*` actually exclude sources
- fix race condition where no module is returned from processing module
-   fix position of standalong semicolon in runtime code

### Features

- add support for `@import` to extenal CSS when using experimental CSS
in node
-   add `i64` support to the deprecated WASM implementation

### Developer Experience

-   expose `EnableWasmLoadingPlugin`
-   add more typings
- generate getters instead of readonly properties in typings to allow
overriding them

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 6am on monday" in timezone
Australia/Sydney, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/google/osv.dev).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMC40IiwidXBkYXRlZEluVmVyIjoiMzQuNDAuMiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koddsson koddsson koddsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keithamus @primer-css @koddsson