Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: github actions cleanup #231

Merged
merged 1 commit into from
Dec 1, 2024
Merged

chore: github actions cleanup #231

merged 1 commit into from
Dec 1, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Nov 20, 2024

Pull Request

Proposed Changes

  • switch to umutable actions on ones that allow it (closes 10 security warnings)
  • solve actionlint issues
    • group commands instead of instead of individual redirects
    • double quote variable to prevent globbing and word splitting

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

- [x] switch to umutable actions on ones that allow it (closes 10 security warnings)
- [x] solve actionlint issues
  - [x] group commands instead of instead of individual redirects
  - [x] double quote variable to prevent globbing and word splitting

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this Nov 20, 2024
@jmeridth jmeridth requested a review from Copilot November 20, 2024 16:26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • .github/workflows/stale.yaml: Evaluated as low risk
  • .github/workflows/major-version-updater.yml: Evaluated as low risk
  • .github/workflows/use-action.yml: Evaluated as low risk

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@zkoppert zkoppert merged commit f74730c into main Dec 1, 2024
37 checks passed
@zkoppert zkoppert deleted the jm_actions_cleanup branch December 1, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants