Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: local testing without Docker #88

Merged
merged 1 commit into from
Feb 29, 2024
Merged

chore: local testing without Docker #88

merged 1 commit into from
Feb 29, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Feb 28, 2024 •
edited by zkoppert
Loading

Pull Request

Proposed Changes

  • update README on how to test locally without Docker
  • add requirements-test.txt to include the required packages for local testing and linting

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@jmeridth
chore: local testing without Docker
1f05fad 
- [x] update README on how to test locally without Docker
- [x] add requirements-test.txt to include the required packages for
local testing and linting

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth requested a review from zkoppert as a code owner February 28, 2024 16:22
@zkoppert zkoppert added documentation Improvements or additions to documentation infrastructure tests or other arch things labels Feb 29, 2024
zkoppert
zkoppert approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! ✨ 🚀

@zkoppert zkoppert merged commit 614409e into github:main Feb 29, 2024
7 checks passed
@jmeridth jmeridth deleted the jm-local-testing branch February 29, 2024 19:53
@jmeridth jmeridth mentioned this pull request Mar 12, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert zkoppert approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation infrastructure tests or other arch things
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmeridth @zkoppert