Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add activeTab, selectedTabIndex props #85

Merged
merged 2 commits into from
Mar 7, 2024
Merged

add activeTab, selectedTabIndex props #85

merged 2 commits into from
Mar 7, 2024

Conversation

keithamus
Copy link
Member

This adds activeTab to get the currently selected tab element, and selectedTabIndex which is a get/set combo (the setter calls selectTab()).

@keithamus keithamus requested a review from a team as a code owner March 6, 2024 14:45
@keithamus keithamus force-pushed the add-activetab-selectedtabindex-props branch from 09ea74a to d2d7712 Compare March 6, 2024 15:00
@keithamus keithamus force-pushed the add-activetab-selectedtabindex-props branch 2 times, most recently from f88161f to 34a8396 Compare March 6, 2024 18:03
@keithamus keithamus force-pushed the add-activetab-selectedtabindex-props branch from 34a8396 to cd10c1a Compare March 6, 2024 18:06
owenniblock
owenniblock reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@owenniblock owenniblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked out why the test was failing! Case error on activeTab 🎉

test/test.js Outdated Show resolved Hide resolved
test/test.js Outdated Show resolved Hide resolved
@owenniblock owenniblock self-requested a review March 7, 2024 10:15
@owenniblock owenniblock merged commit 984ef06 into main Mar 7, 2024
1 check passed
@owenniblock owenniblock deleted the add-activetab-selectedtabindex-props branch March 7, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrotti mperrotti mperrotti approved these changes

@owenniblock owenniblock Awaiting requested review from owenniblock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keithamus @mperrotti @owenniblock