Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-expander-committed event #33

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Add text-expander-committed event #33

merged 1 commit into from
Oct 28, 2022

Conversation

Cbodfield
Copy link
Contributor

@Cbodfield Cbodfield commented Oct 21, 2022

Adding a new event, text-expander-committed, that is dispatched after the underlying input's DOM value has been updated.

This is useful for allowing subscribing listeners to be able to handle when the DOM is updated. The particular use case this is solving is allowing us to sync up with React state when using text-expander.

cc @theinterned

@Cbodfield Cbodfield marked this pull request as ready for review October 21, 2022 21:41
@Cbodfield Cbodfield requested a review from a team as a code owner October 21, 2022 21:41
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@broccolinisoup
Copy link
Contributor

👋🏼 @keithamus This seems like a web component PR, would you mind reviewing it? Thank you!

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cbodfield Cbodfield merged commit 5b5f7ad into main Oct 28, 2022
@Cbodfield Cbodfield deleted the add-committed-event branch October 28, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants