-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow continuation of expander menu #34
Conversation
In our case this was needed for a multi-step autofill, where first you select a type to insert, and then do the actual search.
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to see some tests and documentation for this feature. I'm struggling a little to figure out what this is supposed to do.
@keithamus added some documentation to the README and a few tests. I hope it's clearer now, but to re-iterate: I want to enable something like this:
Where the first dropdown would show the various data types, following a second one that allows the search for the actual entries. |
@keithamus Is there anything still left unclear or requiring further expansion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM
@keithamus fixed the breaking tests |
Thanks for your perseverance on this one @DKhalil |
In our case this was needed for a multi-step autofill, where first you select a type to insert, and then do the actual search.
e.g.: