Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow continuation of expander menu #34

Merged
merged 7 commits into from
Jun 14, 2023
Merged

Conversation

DKhalil
Copy link
Contributor

@DKhalil DKhalil commented Mar 14, 2023

In our case this was needed for a multi-step autofill, where first you select a type to insert, and then do the actual search.

e.g.:

#type:ID

In our case this was needed for a multi-step autofill, where first you select a type to insert, and then do the actual search.
@DKhalil DKhalil requested a review from a team as a code owner March 14, 2023 21:12
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@simurai simurai requested a review from keithamus March 15, 2023 01:46
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to see some tests and documentation for this feature. I'm struggling a little to figure out what this is supposed to do.

@DKhalil
Copy link
Contributor Author

DKhalil commented Mar 15, 2023

@keithamus added some documentation to the README and a few tests. I hope it's clearer now, but to re-iterate:

I want to enable something like this:

#pr:123
#issue:123
#commit:123
#project:1234

Where the first dropdown would show the various data types, following a second one that allows the search for the actual entries.

@DKhalil DKhalil requested a review from keithamus March 16, 2023 14:25
@DKhalil
Copy link
Contributor Author

DKhalil commented Jun 13, 2023

@keithamus Is there anything still left unclear or requiring further expansion?

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@DKhalil
Copy link
Contributor Author

DKhalil commented Jun 13, 2023

@keithamus fixed the breaking tests

@keithamus keithamus merged commit f970a70 into github:main Jun 14, 2023
@keithamus
Copy link
Member

Thanks for your perseverance on this one @DKhalil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants