Don't show empty floating containers on startup #378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you add a floating widget to the dock manager, and then close it before the dock manager is shown, showing the dock manager will currently cause the empty floating dock container to be shown. This fixes this behaviour so that the empty floating container is not shown in this circumstance, making it consistent with the behaviour if the above is performed while the dock manager is visible.
githubuser0xFFFF
added a commit
that referenced
this pull request
Dec 6, 2021
|
I fixed this in master - thank you for your pull request. |
luelista
pushed a commit
to luelista/Qt-Advanced-Docking-System
that referenced
this pull request
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you add a floating dock widget to the dock manager, and then close it before the dock manager is shown, showing the dock manager will currently cause the empty floating dock container to be shown.
This fixes this behaviour so that the empty floating container is not shown in this circumstance, making it consistent with the behaviour if the above is performed while the dock manager is visible.
(I've confirmed that this builds without any other changes, so hopefully I'll avoid a repeat of my last PR… 😛)