Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: show notifications count next to icon in menubar #750

Closed
adufr opened this issue Feb 9, 2024 · 6 comments
Closed

Feature request: show notifications count next to icon in menubar #750

adufr opened this issue Feb 9, 2024 · 6 comments
Assignees
Labels
enhancement New feature or enhancement to existing functionality

Comments

@adufr
Copy link
Contributor

adufr commented Feb 9, 2024

📝 Provide a description of the new feature

It would be nice to show the notifications count next to the Gitify icon in the menubar

From what I saw it's an image, so it should be possible to dynamically generate one by using some 3rd party library.
EDIT: Use the menubarApp.tray.setTitle() API

For example with the "Reminders MenuBar" icon:
image
image

➕ Additional Information

I'd like to work in this if you approve the feature request! 😉

@bmulholland
Copy link
Collaborator

This is probably down to personal preference and workflow. For me, I like the simplicity. See also #728

@adufr
Copy link
Contributor Author

adufr commented Feb 12, 2024

This is probably down to personal preference and workflow. For me, I like the simplicity. See also #728

I agree, some people might not want this feature, but IMO it's sad to prevent other people from benefiting from it; so a setting could be the solution (+ the setting would be a simple checkbox so it wouldn't bring much complexity)

I read #728 and gave my opinion there!

@setchy
Copy link
Member

setchy commented Feb 12, 2024

I think this would be fine so long as the feature is behind a settings flag. Personally, I like the simplicity of the different colored icon.

@adufr
Copy link
Contributor Author

adufr commented Feb 12, 2024

Thank you both for your input 😄
I'll start working on adding this setting as soon as I have some time!

@adufr
Copy link
Contributor Author

adufr commented Feb 16, 2024

Note: this feature is much easier to implement than I anticipated, I don't have to do any on-the-fly image manipulation as the menubarApp.tray.setTitle() API serves my purpose 😛

PR is coming!

@setchy setchy added enhancement New feature or enhancement to existing functionality and removed feature-request labels Feb 29, 2024
@setchy
Copy link
Member

setchy commented Apr 3, 2024

This feature was released today in v5.2.0

@setchy setchy closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants