Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): show notification count in tray #945

Merged
merged 12 commits into from
Apr 2, 2024
Merged

Conversation

setchy
Copy link
Member

@setchy setchy commented Apr 1, 2024

#750

To do list

  • Fix settings view - new option now causes the settings view to scroll, with the footer overflowing
  • Fix App.test.tsx tests
  • Add new unit tests for coverage

Copy link
Contributor

@adufr adufr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, lgtm 👍 It's indeed much cleaner now

@setchy
Copy link
Member Author

setchy commented Apr 2, 2024

Just need a solution to the Settings UI layout/scrolling then we're good to go

@setchy setchy mentioned this pull request Apr 2, 2024
@setchy
Copy link
Member Author

setchy commented Apr 2, 2024

Just need a solution to the Settings UI layout/scrolling then we're good to go

Reworked the Settings screen within #947

Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely to see how modular this change became, thanks @setchy and @adufr!

@afonsojramos afonsojramos added this to the Release 5.2.0 milestone Apr 2, 2024
@setchy setchy merged commit 37d3bef into main Apr 2, 2024
8 of 9 checks passed
@setchy setchy deleted the feature/count-title branch April 2, 2024 16:53
@setchy
Copy link
Member Author

setchy commented Apr 16, 2024

@adufr - shout out, I'm really enjoying this feature. It's nice seeing at a glance just how "green" my notifications backlog is 👏

@adufr
Copy link
Contributor

adufr commented Apr 16, 2024

@adufr - shout out, I'm really enjoying this feature. It's nice seeing at a glance just how "green" my notifications backlog is 👏

Only made possible thanks to you ;)

@bmulholland
Copy link
Collaborator

Yeah actually I was opposed to this at first, but now I use it quite a bit 😅. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants