Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: get token for host #1072

Merged
merged 1 commit into from
Apr 30, 2024
Merged

refactor: get token for host #1072

merged 1 commit into from
Apr 30, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Apr 30, 2024 •
edited
Loading

Update further instances to use getTokenForHost helper

@setchy setchy added the refactor Refactoring of existing feature label Apr 30, 2024
@setchy setchy added this to the Release 5.5.0 milestone Apr 30, 2024
afonsojramos
afonsojramos approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a proper refactor 🧽

@afonsojramos afonsojramos merged commit 7acac1c into main Apr 30, 2024
9 checks passed
@afonsojramos afonsojramos deleted the refactor/get-token branch April 30, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
Release 5.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @afonsojramos