Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(mocks): use consistent naming #1142

Merged
merged 5 commits into from
May 28, 2024
Merged

refactor(mocks): use consistent naming #1142

merged 5 commits into from
May 28, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented May 25, 2024

Refactor mocks to use consistent naming convention.

I also moved github response mocks under the /api/ folder so they don't get intermingled with application mocks

@setchy setchy added refactor Refactoring of existing feature test Enhancements to test coverage or quality labels May 25, 2024
@setchy setchy added this to the Release 5.7.0 milestone May 25, 2024
afonsojramos
afonsojramos requested changes May 27, 2024
View reviewed changes
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think naming things mocked over mock is the standard... Take a look at vitest's mocking section. They are mocks, not a "mocked" X. Same goes for Jest, mockFn, not mockedFn 🤔

@setchy
Copy link
Member Author

setchy commented May 27, 2024

I don't think naming things mocked over mock is the standard... Take a look at vitest's mocking section. They are mocks, not a "mocked" X. Same goes for Jest, mockFn, not mockedFn 🤔

Take 2 😄

@setchy setchy requested a review from afonsojramos May 27, 2024 12:33
@afonsojramos afonsojramos merged commit e3dbb24 into main May 28, 2024
7 checks passed
@afonsojramos afonsojramos deleted the refactor/mocks-consistency branch May 28, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
refactor Refactoring of existing feature test Enhancements to test coverage or quality
Projects
None yet
Milestone
Release 5.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @afonsojramos