Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add datetime error handling #1167

Merged
merged 4 commits into from
Jun 2, 2024
Merged

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 1, 2024

I'm take a bit of an educated guess, but this should catch any null or split issues with our use of date-fns lib

Fixes: #1166

@setchy setchy added the bug Something isn't working label Jun 1, 2024
@setchy setchy added this to the Release 5.7.0 milestone Jun 1, 2024
@setchy setchy changed the title fix: add error handling for iso date distance fix: add datetime error handling Jun 1, 2024
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seemed to fix it indeed!

@afonsojramos afonsojramos merged commit f2daee4 into main Jun 2, 2024
11 checks passed
@afonsojramos afonsojramos deleted the fix/handle-formatted-date-errors branch June 2, 2024 23:50
@xShteff
Copy link

xShteff commented Jun 3, 2024

Would it perhaps make sense to release 5.6.1 patch with this fix, to fix people's installs? (:

@setchy
Copy link
Member Author

setchy commented Jun 3, 2024

Would it perhaps make sense to release 5.6.1 patch with this fix, to fix people's installs? (:

We'll be releasing 5.7.0 early this week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitify blank/white screen with loading bar on top than stop
3 participants