Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: user's name can be null #1173

Merged
merged 1 commit into from
Jun 4, 2024
Merged

refactor: user's name can be null #1173

merged 1 commit into from
Jun 4, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 4, 2024 •
edited
Loading

improve typing for user

@setchy setchy added the refactor Refactoring of existing feature label Jun 4, 2024
@setchy setchy added this to the Release 5.7.0 milestone Jun 4, 2024
afonsojramos
afonsojramos approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to double check that, but checks out!

@afonsojramos afonsojramos merged commit e0bfb0d into main Jun 4, 2024
11 checks passed
@afonsojramos afonsojramos deleted the refactor/name-null branch June 4, 2024 00:16
@setchy
Copy link
Member Author

setchy commented Jun 4, 2024

Had to double check that, but checks out!

Haha thx, yeah, found this today with my test github account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
Release 5.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @afonsojramos