Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): open links in foreground or background #1376

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jul 13, 2024

No description provided.

@setchy setchy added this to the Release 5.11.0 milestone Jul 13, 2024
@github-actions github-actions bot added the enhancement New feature or enhancement to existing functionality label Jul 13, 2024
@afonsojramos
Copy link
Member

I suppose here is where @bmulholland's point comes into play the most. Why not just leave this as a cmd + click action, and remove the setting altogether?

@bmulholland
Copy link
Collaborator

I still don't mind Cmd+Click, but do wonder about discoverability.

src/__mocks__/state-mocks.ts Dismissed Show dismissed Hide dismissed
src/__mocks__/state-mocks.ts Dismissed Show dismissed Hide dismissed
@setchy setchy merged commit e9c7a64 into main Jul 15, 2024
12 checks passed
@setchy setchy deleted the feature/system-setting-open-preference branch July 15, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants