feat(api): use conditional requests and fetch all inbox notifications

[setchy]

Closes #1124
Closes #356

Update our API Request With Auth function to:

• support paginated endpoints and unpaginating response data
• conditionally set Cache-Control request header depending on the api url
  • for /notifications we do not want to cache request/response (current behavior)
  • for all other api requests, we use the default browser caching based on the GitHub API response (60 seconds)

Appreciate some hands to test this branch locally before merging 🙏

[setchy]

@bmulholland @afonsojramos - thoughts on whether we need to place a ceiling on the total number of notifications we unpaginate, or leave as-is (fetch all pages)?

I've tested with ~650 notifications and it seems to be fine. Maybe we add a ceiling only if there are reports of rate-limiting?

[setchy]

Moving back to draft as the tests require some rework after merging #1419

[bmulholland]

thoughts on whether we need to place a ceiling on the total number of notifications we unpaginate, or leave as-is (fetch all pages)?

Maybe just leave it, but add a way to report to the user "you have too many notifications, it hits rate limits, you're on your own"? :)

[setchy]

Finally ready for this to be considered for merging. Clearing the previous approval(s) since it's been sitting for a little while

[bmulholland]

Will test locally. To start, I see this in console:

13:50:17.163 › Error occurred while fetching details for PullRequest notification: feat(lorem): add character length parameter to lorem.text TypeError: Cannot read properties of null (reading 'login')

[setchy]

Will test locally. To start, I see this in console:

13:50:17.163 › Error occurred while fetching details for PullRequest notification: feat(lorem): add character length parameter to lorem.text TypeError: Cannot read properties of null (reading 'login')

🤔 - that's pretty unusual

[setchy]

I've been running it locally for the past week and haven't had any console log entries like that

[setchy]

@brandonweiss - can you check if you're getting the above login console error using either main or the latest release please 🙏

My best guess is that PR, for some reason, doesn't have a PR user

gitify/src/utils/subject.ts

Lines 280 to 285 in fa77c99

	user: {
	login: prCommentUser?.login ?? pr.user.login,
	html_url: prCommentUser?.html_url ?? pr.user.html_url,
	avatar_url: prCommentUser?.avatar_url ?? pr.user.avatar_url,
	type: prCommentUser?.type ?? pr.user.type,
	},

[setchy]

Added a new Notification Setting to control fetching all unread inbox notifications, just in case

[bmulholland]

@setchy the console message may well be unrelated, unfortunately I only had that PR in my notifications exactly while testing the branch. I think you're right, though: the PR author deleted their account.

[bmulholland]

FYI, I've been using this branch for the last day and it seems to be working well for me :)

[setchy]

FYI, I've been using this branch for the last day and it seems to be working well for me :)

Likewise - do we feel comfortable enough to merge this change? Itching to ship the next release