feat: add linter & switch formatter to biome #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setchy
requested changes
Apr 6, 2024
setchy
reviewed
Apr 6, 2024
Single for normal JS, double for JSX, but yeah 👌 |
setchy
reviewed
Apr 8, 2024
setchy
approved these changes
Apr 8, 2024
setchy
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we don't even have a linter. And however the app has stayed quite well in terms of code quality, it might be a good opportunity to add one.
https://biomejs.dev/ tries to be a prettier (a more performant alternative with almost 100% of prettier rules already supported) and eslint replacement (without hundreds of plugins).
Further fixes other than the automatic ones will be done in a different PR.
Following PRs: #977 #978